-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Username OIDC flow based on comments #463
Conversation
3c373e5
to
9029402
Compare
cc @znewman01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Sorry for the delay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some minor comments in there
Whoops, #483 submitted the change too. I'll rebase and update based on the comments. |
Oh wow, somehow I only saw the second commit there with the tests. |
9029402
to
b2186c0
Compare
Signed-off-by: Hayden Blauzvern <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
All looks great! |
Signed-off-by: Hayden Blauzvern <[email protected]>
Summary
Signed-off-by: Hayden Blauzvern [email protected]
Ticket Link
Fixes #398
Release Note