Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Username OIDC flow based on comments #463

Merged
merged 2 commits into from
Mar 19, 2022

Conversation

haydentherapper
Copy link
Contributor

@haydentherapper haydentherapper commented Mar 9, 2022

Summary

Signed-off-by: Hayden Blauzvern [email protected]

Ticket Link

Fixes #398

Release Note

Added OIDC issuer type for username subjects

@haydentherapper
Copy link
Contributor Author

cc @znewman01

Copy link
Member

@dlorenc dlorenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Sorry for the delay.

Copy link
Contributor

@znewman01 znewman01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor comments in there

pkg/api/api_test.go Show resolved Hide resolved
pkg/challenges/challenges.go Outdated Show resolved Hide resolved
pkg/challenges/challenges.go Outdated Show resolved Hide resolved
pkg/challenges/challenges.go Outdated Show resolved Hide resolved
pkg/challenges/challenges_test.go Show resolved Hide resolved
pkg/challenges/challenges_test.go Show resolved Hide resolved
@haydentherapper
Copy link
Contributor Author

Whoops, #483 submitted the change too. I'll rebase and update based on the comments.

@dlorenc
Copy link
Member

dlorenc commented Mar 18, 2022

Whoops, #483 submitted the change too. I'll rebase and update based on the comments.

Oh wow, somehow I only saw the second commit there with the tests.

@haydentherapper haydentherapper changed the title Add Username scoped to domain OIDC type Update Username OIDC flow based on comments Mar 18, 2022
Copy link
Contributor Author

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pkg/api/api_test.go Show resolved Hide resolved
pkg/challenges/challenges.go Outdated Show resolved Hide resolved
pkg/challenges/challenges.go Outdated Show resolved Hide resolved
pkg/challenges/challenges_test.go Show resolved Hide resolved
pkg/challenges/challenges_test.go Show resolved Hide resolved
pkg/challenges/challenges.go Outdated Show resolved Hide resolved
@znewman01
Copy link
Contributor

All looks great!

Signed-off-by: Hayden Blauzvern <[email protected]>
@dlorenc dlorenc merged commit 374ebab into sigstore:main Mar 19, 2022
@haydentherapper haydentherapper deleted the uri-with-subject branch March 21, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OIDC enhancement: Support for additional OIDC subjects
3 participants