Generate larger, compliant serial numbers #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydentherapper
force-pushed
the
serial-compliant
branch
from
6cc48df
to
514deeb
Compare
dlorenc
approved these changes
Apr 1, 2022
bobcallaway
approved these changes
Apr 2, 2022
Codecov Report
@@ Coverage Diff @@
## main #500 +/- ##
==========================================
- Coverage 47.97% 42.35% -5.63%
==========================================
Files 14 16 +2
Lines 1063 1216 +153
==========================================
+ Hits 510 515 +5
- Misses 480 626 +146
- Partials 73 75 +2
Continue to review full report at Codecov.
|
UUIDs generate 16 byte serial numbers. Serial numbers can be no larger than 20 bytes. They also must be positive, giving us 159 bits to generate a serial number. Signed-off-by: Hayden Blauzvern <[email protected]>
haydentherapper
force-pushed
the
serial-compliant
branch
from
49f50f9
to
1d1ff85
Compare
haydentherapper
added a commit
to haydentherapper/fulcio
that referenced
this pull request
Apr 6, 2022
UUIDs generate 16 byte serial numbers. Serial numbers can be no larger than 20 bytes. They also must be positive, giving us 159 bits to generate a serial number. Signed-off-by: Hayden Blauzvern <[email protected]>
haydentherapper
added a commit
to haydentherapper/fulcio
that referenced
this pull request
Apr 9, 2022
UUIDs generate 16 byte serial numbers. Serial numbers can be no larger than 20 bytes. They also must be positive, giving us 159 bits to generate a serial number. Signed-off-by: Hayden Blauzvern <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UUIDs generate 16 byte serial numbers. Serial numbers can be no larger
than 20 bytes. They also must be positive, giving us 159 bits to
generate a serial number.
This does not affect prod currently, since CA Service generates its own serial numbers. This will affect prod once we switch to using an intermediate CA.
Signed-off-by: Hayden Blauzvern [email protected]
Summary
Ticket Link
Fixes
Release Note