Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use provided HTTP client instead when fetching root cert #502

Merged
merged 1 commit into from
Apr 2, 2022
Merged

Use provided HTTP client instead when fetching root cert #502

merged 1 commit into from
Apr 2, 2022

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Apr 1, 2022

Signed-off-by: Jason Hall [email protected]

Fixes #501

Client request to fetch root cert honors provided timeout and useragent

@vaikas

@imjasonh imjasonh mentioned this pull request Apr 1, 2022
Closed
vaikas
vaikas approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov-commenter
Copy link

Codecov Report

Merging #502 (1888c99) into main (56c15d6) will decrease coverage by 0.08%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
- Coverage   47.97%   47.89%   -0.09%     
==========================================
  Files          14       14              
  Lines        1063     1067       +4     
==========================================
+ Hits          510      511       +1     
- Misses        480      482       +2     
- Partials       73       74       +1
Impacted Files Coverage Δ
pkg/api/client.go 75.22% <40.00%> (-1.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56c15d6...1888c99. Read the comment docs.

@dlorenc dlorenc merged commit 5b27cd3 into sigstore:main Apr 2, 2022
haydentherapper pushed a commit to haydentherapper/fulcio that referenced this pull request Apr 6, 2022
@imjasonh @haydentherapper
Use provided HTTP client instead when fetching root cert (sigstore#502)
4c6d51c 
Signed-off-by: Jason Hall <[email protected]>
haydentherapper pushed a commit to haydentherapper/fulcio that referenced this pull request Apr 9, 2022
@imjasonh @haydentherapper
Use provided HTTP client instead when fetching root cert (sigstore#502)
a0e56f1 
Signed-off-by: Jason Hall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlorenc dlorenc dlorenc approved these changes

@vaikas vaikas vaikas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pkg/api/client.RootCert should use the provided *http.Client
4 participants
@imjasonh @codecov-commenter @dlorenc @vaikas