-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CSR support for key delivery and proof of possession #527
Conversation
There are three options for the API changes:
Currently leaning towards (2), it's a cleaner gRPC API. |
Many ecosystems and libraries have support for generating CSRs, but do not have easy-to-use utilities for generating encoded public keys. A CSR provides a simple way to send an encoded public key, along with a proof of possession since CSRs are self-signed. Existing clients do not have to change their behavior, as we will continue to support providing a public key and signed challenge. Signed-off-by: Hayden Blauzvern <[email protected]>
Signed-off-by: Hayden Blauzvern <[email protected]>
Looking forward to seeing this come through! +1 to (2), I think the plan of "make gRPC API nice" is the right one and HTTP will always be a bit hacky regardless of this choice. I think (3) is a bad idea because the number of possible encodings may continue to grow. |
This provides a cleaner API. Signed-off-by: Hayden Blauzvern <[email protected]>
Signed-off-by: Hayden Blauzvern <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #527 +/- ##
==========================================
+ Coverage 33.75% 35.47% +1.72%
==========================================
Files 18 18
Lines 1357 1415 +58
==========================================
+ Hits 458 502 +44
- Misses 836 853 +17
+ Partials 63 60 -3
Continue to review full report at Codecov.
|
FYI @di |
Signed-off-by: Hayden Blauzvern <[email protected]>
Signed-off-by: Hayden Blauzvern <[email protected]>
Summary
Many ecosystems and libraries have support for generating CSRs, but do
not have easy-to-use utilities for generating encoded public keys. A CSR
provides a simple way to send an encoded public key, along with a proof
of possession since CSRs are self-signed.
Existing clients do not have to change their behavior, as we will
continue to support providing a public key and signed challenge.
Signed-off-by: Hayden Blauzvern [email protected]
Ticket Link
Fixes #503
Release Note