Read public key of CT log from path to verify SCTs #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an optional flag to verify an SCT before returning it to the client. Signed-off-by: Hayden Blauzvern <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #529 +/- ##
==========================================
- Coverage 33.75% 33.52% -0.23%
==========================================
Files 18 18
Lines 1357 1357
==========================================
- Hits 458 455 -3
- Misses 836 838 +2
- Partials 63 64 +1
Continue to review full report at Codecov.
|
|
Tested with a local instance of Fulcio, using the public key from config/ctfe/rootkey.pem. |
dlorenc
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optional flag to verify an SCT before returning it to the
client.
Signed-off-by: Hayden Blauzvern [email protected]
Summary
Ticket Link
Fixes
Release Note