-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Issuer
and Principal
abstractions
#558
Conversation
b69f357
to
3bd5424
Compare
Codecov Report
@@ Coverage Diff @@
## main #558 +/- ##
==========================================
+ Coverage 35.68% 36.64% +0.95%
==========================================
Files 18 19 +1
Lines 1415 1441 +26
==========================================
+ Hits 505 528 +23
- Misses 851 853 +2
- Partials 59 60 +1
Continue to review full report at Codecov.
|
3bd5424
to
61328a1
Compare
61328a1
to
42660dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a couple nits and the other open comment on pointer vs val
479e7a3
to
042f9b7
Compare
042f9b7
to
177437e
Compare
Includes principal and issuer abstracts and an issuerpool Signed-off-by: Nathan Smith <[email protected]>
177437e
to
7256e2a
Compare
Huh I can't merge. Maybe because I rerequested Dan's review? I don't have permissions to dismiss that unfortunately |
Merged, it needs write permissions. |
Summary
Adds identity package with
Issuer
andPrincipal
abstractions as well as anIssuerPool
implementation that matches a token against a pool is issuers to authenticate. This work is part of a larger refactor of our identity issuer code as described here.Future work includes:
Ticket Link
Partially addresses #275 along with the other future works describe above
Release Note