Add new Issuer and Principal abstractions
#558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsmith5
force-pushed
the
issuer-abstraction
branch
from
b69f357
to
3bd5424
Compare
Codecov Report
@@ Coverage Diff @@
## main #558 +/- ##
==========================================
+ Coverage 35.68% 36.64% +0.95%
==========================================
Files 18 19 +1
Lines 1415 1441 +26
==========================================
+ Hits 505 528 +23
- Misses 851 853 +2
- Partials 59 60 +1
Continue to review full report at Codecov.
|
dlorenc
previously approved these changes
May 5, 2022
nsmith5
force-pushed
the
issuer-abstraction
branch
from
3bd5424
to
61328a1
Compare
nsmith5
force-pushed
the
issuer-abstraction
branch
from
61328a1
to
42660dd
Compare
haydentherapper
previously approved these changes
May 5, 2022
nsmith5
force-pushed
the
issuer-abstraction
branch
2 times, most recently
from
479e7a3
to
042f9b7
Compare
haydentherapper
previously approved these changes
May 5, 2022
nsmith5
force-pushed
the
issuer-abstraction
branch
from
042f9b7
to
177437e
Compare
Includes principal and issuer abstracts and an issuerpool Signed-off-by: Nathan Smith <[email protected]>
nsmith5
force-pushed
the
issuer-abstraction
branch
from
177437e
to
7256e2a
Compare
haydentherapper
approved these changes
May 5, 2022
|
Huh I can't merge. Maybe because I rerequested Dan's review? I don't have permissions to dismiss that unfortunately |
|
Merged, it needs write permissions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds identity package with
IssuerandPrincipalabstractions as well as anIssuerPoolimplementation that matches a token against a pool is issuers to authenticate. This work is part of a larger refactor of our identity issuer code as described here.Future work includes:
Ticket Link
Partially addresses #275 along with the other future works describe above
Release Note