-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client options testing #562
Conversation
Signed-off-by: Nathan Smith <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #562 +/- ##
==========================================
+ Coverage 36.67% 39.03% +2.35%
==========================================
Files 19 19
Lines 1445 1445
==========================================
+ Hits 530 564 +34
+ Misses 855 819 -36
- Partials 60 62 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gRPC generates its own clients, so I think the plan will be to just remove the API client entirely.
Okie, We can drop this if GRPC cut over is happening soon. I was just looking around the repo for easy test coverage to add honestly 😆 |
@@ -0,0 +1,62 @@ | |||
// | |||
// Copyright 2021 The Sigstore Authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Copyright 2021 The Sigstore Authors. | |
// Copyright 2022 The Sigstore Authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right we should update the boilerplate everywhere and the boilerplate test to match...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, this is added when you create the file first time.
if is a new file you add the current year
Summary
Adds some tests for the
WithTimeout
andWithUserAgent
options for the client. While this legacy client will be deprecated soon, these were some easy tests to write so why not? Not sure if we're keeping library API compat in the deprecation to GRPC, but if so perhaps these can be good tests to make sure we reimplement this when cutting over to the new client.Ticket Link
Release Note