-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consume identity.Principal
in CA abstraction
#570
Consume identity.Principal
in CA abstraction
#570
Conversation
ea2b10e
to
e8b998e
Compare
@znewman01 for refactoring mentorship eyeballs 🙏🏻 |
a1cf313
to
a1ca128
Compare
a1ca128
to
7c9db98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Modifies the CA abstraction to consume identity.Principal instead of challenges.ChallengeResult. Also implements the indentity.Principal methods for ChallengeResult. Signed-off-by: Nathan Smith <[email protected]>
7c9db98
to
380c64c
Compare
(Just cleaning up that merge conflict) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving open for a bit if @znewman01 has any comments
Codecov Report
@@ Coverage Diff @@
## main #570 +/- ##
==========================================
- Coverage 44.29% 43.95% -0.35%
==========================================
Files 21 21
Lines 1517 1513 -4
==========================================
- Hits 672 665 -7
- Misses 771 777 +6
+ Partials 74 71 -3
Continue to review full report at Codecov.
|
LGTM, thanks! |
Summary
As part of #275, we'd like to move away from the
challenges.ChallengeResult
data structure and useidentity.Principal
andidentity.Issuer
instead. This PR changes theca.CertificateAuthority
to consumeidentity.Principal
and a public key instead ofchallenges.ChallengeResult
.Ticket Link
Related to #275
Release Note