Add some tests for challenges #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 13, 2022 11:23
Signed-off-by: Nathan Smith <[email protected]>
Signed-off-by: Nathan Smith <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #583 +/- ##
==========================================
+ Coverage 43.05% 46.23% +3.17%
==========================================
Files 21 21
Lines 1498 1501 +3
==========================================
+ Hits 645 694 +49
+ Misses 781 736 -45
+ Partials 72 71 -1
Continue to review full report at Codecov.
|
nsmith5
force-pushed
the
test-challengeresult
branch
from
55f76ed
to
f242c25
Compare
haydentherapper
previously approved these changes
May 13, 2022
nsmith5
force-pushed
the
test-challengeresult
branch
from
f242c25
to
e26c017
Compare
Signed-off-by: Nathan Smith <[email protected]>
nsmith5
force-pushed
the
test-challengeresult
branch
from
e26c017
to
e7d6192
Compare
haydentherapper
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just a smattering of different tests for challenge results. Wanted to increase coverage before migrating into issuer abstraction.