-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API for fetching Fulcio configuration #608
Conversation
cc @var-sdk |
8de5b99
to
3ce9ef3
Compare
Codecov Report
@@ Coverage Diff @@
## main #608 +/- ##
==========================================
+ Coverage 59.86% 60.92% +1.06%
==========================================
Files 26 26
Lines 1582 1638 +56
==========================================
+ Hits 947 998 +51
- Misses 558 562 +4
- Partials 77 78 +1
Continue to review full report at Codecov.
|
@bobcallaway Any idea why the version of |
The version installed in the CI env doesn't match what you have locally. fulcio/.github/workflows/main.yml Line 39 in ed8f649
fulcio/.github/workflows/main.yml Line 48 in ed8f649
|
@haydentherapper @bobcallaway what is the version we need to run? |
@cpanato I have |
ok, otherwise i can make a pr to install a version that we want |
@cpanato A PR would be great - Should we automatically pick up the latest version? |
Hm, not sure why the regex isn't working, |
If I try to replicate this locally, by modifying one of the generated build files to have an older version, running Unable to reproduce the issue |
This API provides the following: * All OIDC issuers, including the meta/wildcard issuers * The expected audience of the token * The claim that must be signed for a proof of possession * The SPIFFE trust domain, when the issuer is of type SPIFFE Signed-off-by: Hayden Blauzvern <[email protected]>
Signed-off-by: Hayden Blauzvern <[email protected]>
…te the index too Signed-off-by: Hayden Blauzvern <[email protected]>
fb3ccb7
to
feb67a2
Compare
Signed-off-by: Hayden Blauzvern <[email protected]>
Issue with workflow has been fixed, we had to also match on // - protoc v1.2.3, in addition to // protoc v.1.2.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for fixing the regex!
string challenge_claim = 4; | ||
// The expected SPIFFE trust domain. Only present when the OIDC issuer issues tokens for SPIFFE identities. | ||
string spiffe_trust_domain = 5; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: new line
This API provides the following:
This has only been added to the V2 API, as we are no longer updating the V1 API.
Signed-off-by: Hayden Blauzvern [email protected]
Summary
Ticket Link
Fixes #607
Release Note