Add probes to Fulcio deployment #506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Soyland <[email protected]>
codysoyland
force-pushed
the
codysoyland/fulcio-probes
branch
from
4b580f0
to
7e952c5
Compare
codysoyland
commented
Apr 11, 2023
| }, | ||
| "readinessProbe": { | ||
| "description": "Readiness probe configuration", | ||
| "$ref": "https://kubernetesjsonschema.dev/v1.18.1/_definitions.json#/definitions/io.k8s.api.core.v1.Probe" |
There was a problem hiding this comment.
Any thoughts on using these references to https://kubernetesjsonschema.dev? Not sure what implications this has, as I don't see any $ref references within the Sigstore Helm charts.
There was a problem hiding this comment.
How did you generate these values ?
Signed-off-by: Cody Soyland <[email protected]>
Signed-off-by: Cody Soyland <[email protected]>
Signed-off-by: Bob Callaway <[email protected]>
bobcallaway
approved these changes
Jul 3, 2023
|
fixed by #568 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This adds
readinessProbeandlivenessProbeto the Fulcio deployment.Fulcio doesn't have health endpoints, so I'm using
/api/v1/rootCert.Existing or Associated Issue(s)
Additional Information
Checklist
Chart.yamlaccording to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.