-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial attempt to fix #560 #905
base: main
Are you sure you want to change the base?
Conversation
Enables decorations for user specified tags - currently supporting only a single decoration - a 'prefix' to be added to the page name. Prefix is handled in the top bar title, page navigator as well as links.
This looks promising. Definitely a good starting point to a more elaborate implementation. I'll have a closer look soon! |
A few issues I've found:
Some of these issues may be harder to get done. If you get stuck or you'd like me to take over let me know. This is a good start, and this is definitely something I'd like to get in soon, so happy to help! |
Thanks Zef. Happy to take another shot at it - after all I'm loving SilverBullet a bit too much :)
|
1. The decorator prefix being an editable component in the top bar. It is now rendered in it's on container, separate from the MiniEditor and is hence not editable by the user. This also means we need no custom logic in the topbar page rename code. 2. The decorators not being applied on page reload. The page list gets updated post the "page-loaded" event in most cases. Hence if the current page gets a prefix, we need to force a render.
Enables decorations for user specified tags - currently supporting only a single decoration - a 'prefix' to be added to the page name. Prefix is handled in the top bar title, page navigator as well as links.
Since visually identifying my defined object types was somewhat important for me, I took a stab at #560 - Quite unfamiliar with typescript and in general PWAs - so there could be a lot that can be improved and even better ways to do this. Open to suggestions.
TODO: Handle this in queries as well, at least when rendered via templates - but I'm wondering if that could be achieved better by simply extracting out the prefix as an attribute and using that (leaving it to the user)