Pr #1
Open
Pr #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
May 31, 2021 00:47
Submit user arguments to xinit instead of the xserver. Hardcode all arguments for the xserver. Do all exec's with absolute pathnames. (Prevent users to mess with executables within the search path, or submit bad arguments to xorg) Added code to drop suid rights of sxinit; I also believe it is better having a small suid executable, which is possible to check for security flaws, than having a big xserver with countless arguments suid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, and thanks for your good work.
I modified sxinit a bit.
Specifically, I do believe, it would be better having sxinit suid,
and the Xserver ideally only executable by root.
While the xserver is a quite complex program,
which might also have it's vulnerabilities;
sxinit is understandable.
I commented my changes in the source.
Furthermore I added a config file, which is able to compile sxinit with "minilib".
(Have to do some advertising for my project)
make -f minilib.conf
might work.
Would be great to have my modifications upstream.
Best regards, Michael