New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ind2x!(x, grid ind) #33

Open

zsunberg opened this issue Mar 6, 2020 · 0 comments

Member

zsunberg commented Mar 6, 2020 •

edited

Loading

To be consistent with the julia style guide https://docs.julialang.org/en/v1/manual/style-guide/index.html#Write-functions-with-argument-ordering-similar-to-Julia-Base-1, we should have

ind2x!(x, grid, ind)

rather than

ind2x!(grid, ind, x)

This should not be a terrible change since we can do

@deprecate ind2x!(grid::AbstractGrid, ind, x) ind2x!(x, grid, ind)

There may be other functions that should be changed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment