💥 Resolve pyinstaller release errors #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmdvs
force-pushed
the
fix-pyinstaller-release-errors
branch
from
5d54f9c
to
bcd669c
Compare
tmdvs
changed the title
tmdvs
commented
Mar 1, 2024
| - name: Build | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install pyinstaller | ||
| pip install "pyinstaller>=5.12" |
There was a problem hiding this comment.
This is the specific "fix" - everything else is linting :feelsgood:
andreivladmatei
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were encountering a specific issue with Pyinstaller when trying to embed the universal binary in the Sketch bundle. We're mitigating this for now by moving to a specific Pyinstaller release