🔨 Improve the reliability of web font matching #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmdvs
commented
May 17, 2024
Comment on lines
+53
to
+55
| font_names["subfamily"].lower() == subfamily.lower() | ||
| or font_names["subfamily"].replace(" ", "").lower() | ||
| == subfamily.replace(" ", "").lower() |
There was a problem hiding this comment.
Fonts seem to use naming conventions like either "SemiBold" or "Semi Bold", this little tweak gives us a fuzzier match while still scoped to the font family.
arseniocosta1
previously approved these changes
May 17, 2024
tmdvs
force-pushed
the
feat/improved-webfont-matching
branch
from
8d5d844
to
5fe4ef1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #118 we patched google web font downloading to fix a breaking change on Google's end.
However, the font matching wasn't the most reliable, as we attempted to match against file names rather than the family and style names from the font file itself. I've refactored this to use the more reliable latter. However, the downside is downloading each font file for the family. The previous implementation did this but as a single ZIP file. Given fonts are typically very small, and ZIPing them appears to make a negligible difference, I've gone for a slight bandwidth increase for better reliability/conversion results.
Note: We will still see some errors downloading fonts regarding text styles with additional variant info in subfamily strings (such as "Italic"). But I'm keen to avoid trimming/fiddling with the subfamily string too much.