Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to image pathing #716

Merged
merged 7 commits into from
Apr 26, 2024
Merged

Updates to image pathing #716

merged 7 commits into from
Apr 26, 2024

Conversation

SkillBL
Copy link
Contributor

@SkillBL SkillBL commented Apr 25, 2024

Summary

Image references break when viewed from external domains

Changes

Image paths will now resolve properly internally and externally

Closes:

Task list

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

@SkillBL
Update 1-create-a-branch.md
072b1e9 
Updated image include pathing
@SkillBL
Update 2-commit-a-file.md
3789605 
Updated image include pathing
@SkillBL
Update 3-open-a-pull-request.md
1c0bd3a 
Updated image include pathing
@SkillBL
Update 4-merge-your-pull-request.md
daa8bdb 
Updated image include pathing
@SkillBL
Update 2-commit-a-file.md
b8a7bf7 
Updated image include pathing
@SkillBL
Update 3-open-a-pull-request.md
b0417c4 
updated image tags
@SkillBL
Update 4-merge-your-pull-request.md
576c2a9 
Updated image tags
WirelessLife
WirelessLife approved these changes Apr 26, 2024
View reviewed changes
Copy link

@WirelessLife WirelessLife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to update image URLs

@WirelessLife WirelessLife merged commit 36751c8 into skills:main Apr 26, 2024
2 checks passed
@sinsukehlab
Copy link
Contributor

Hey, now the image paths will be broken in README.
Please revert this commit. The image paths were not broken at all before this PR.
Cf. https://github.com/klug2024/skills-introduction-to-github

sinsukehlab added a commit to sinsukehlab/introduction-to-github that referenced this pull request Apr 30, 2024
@sinsukehlab
Revert "Updates to image pathing (skills#716)"
bae5bd5 
This reverts commit 36751c8.
@sinsukehlab sinsukehlab mentioned this pull request Apr 30, 2024
Merged
2 tasks
hectorsector pushed a commit that referenced this pull request Apr 30, 2024
@sinsukehlab
Revert "Updates to image pathing" (#719)
86a4bea 
* Revert "Updates to image pathing (#716)"

This reverts commit 36751c8.

* Use markdown syntax for images

![alt](path)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WirelessLife WirelessLife WirelessLife approved these changes

@Deterty88 Deterty88 Deterty88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SkillBL @sinsukehlab @WirelessLife @Deterty88