Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE support #19

Closed
srmagura opened this issue Feb 23, 2018 · 4 comments
Closed

IE support #19

srmagura opened this issue Feb 23, 2018 · 4 comments
Labels

Comments

@srmagura
Copy link

srmagura commented Feb 23, 2018

Thank you for this library - it works very well in Chrome and Firefox.

I have run into two problems when testing it in IE 11 though. Does react-hint support IE?

The most noticeable issue is that, in IE, the tooltips do not appear in the demo (https://react-hint.js.org/).

The other issue I am having in IE is that hovering over a select that has a tooltip causes a React "Maximum update depth exceeded". There is no issue in other browsers. I can try to provide a small example reproducing the error if you want.

@slmgc
Copy link
Owner

slmgc commented Feb 24, 2018

Hi, there was no initial intent to support IE11 or older, but I can try looking into this issue.

@slmgc slmgc added the bug label Feb 24, 2018
@srmagura
Copy link
Author

That's fine. Please don't feel like you need to add IE support on my behalf.

If anyone else is interested, here is the quick & dirty fallback I am using for IE. Emphasis on the "dirty".

slmgc added a commit that referenced this issue Mar 6, 2018
@slmgc
Copy link
Owner

slmgc commented Mar 6, 2018

Sorry for a late fix, it took me a while to find some spare time to debug this issue. Should work fine in IE11.

@slmgc slmgc closed this as completed Mar 6, 2018
@srmagura
Copy link
Author

srmagura commented Mar 6, 2018

Tested it in my application and it works. Great job!

slmgc added a commit that referenced this issue Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants