Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARIA compilant #28

Closed
Kikobeats opened this issue Jul 24, 2018 · 4 comments
Closed

ARIA compilant #28

Kikobeats opened this issue Jul 24, 2018 · 4 comments
Labels
enhancement

Comments

@Kikobeats
Copy link

Kikobeats commented Jul 24, 2018 •
edited
Loading

Hello,

I think could easy make this library ARIA compliant

As referenced:
@slmgc
Copy link
Owner

slmgc commented Jul 24, 2018

Hi @Kikobeats,

That's a good idea. Does it mean that the tooltip itself needs to have only role="tooltip" attribute to be ARIA-compliant?

slmgc added a commit that referenced this issue Aug 2, 2018
@slmgc
#28: Make react-hint ARIA-compliant
e2ef437
slmgc added a commit that referenced this issue Aug 2, 2018
@slmgc
#28: Make react-hint ARIA-compliant
6bcd965
@slmgc slmgc closed this as completed Aug 2, 2018
@Kikobeats
Copy link
Author

Not just role, adding an ARIA label when the tooltip is hidden or no 🙂

@Kikobeats
Copy link
Author

A relevant reference: https://github.com/egoens/react-aria-tooltip/blob/c1679fc4c252a382c3e7115f2be20ff0bfa2abab/src/tooltip-content.jsx#L12

@slmgc
Copy link
Owner

slmgc commented Aug 3, 2018

@Kikobeats it doesn't make any sense to add such a label as there is no dom element to show the hidden status :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kikobeats @slmgc