Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add directory input to Maven builder #2538

Merged
merged 13 commits into from
Aug 15, 2023

Conversation

AdamKorcz
Copy link
Collaborator

Adds another input for the Maven builder to allow the user to specify the project directory. The current problem this solves is to make slsa-framework/example-package#253 work.

This was suggested by @laurentsimon in slsa-framework/example-package#253 (comment)

@laurentsimon laurentsimon changed the title chore: Add directory input to Maven builder feat: Add directory input to Maven builder Aug 4, 2023
Copy link
Collaborator

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. You could do some verification on the path to make sure it's under the workspace, something like https://github.com/slsa-framework/slsa-github-generator/blob/main/.github/actions/secure-download-artifact/action.yml#L42-L48

Signed-off-by: AdamKorcz <[email protected]>
Signed-off-by: AdamKorcz <[email protected]>
@AdamKorcz
Copy link
Collaborator Author

@laurentsimon Could you have another look, please?

.github/workflows/builder_maven_slsa3.yml Outdated Show resolved Hide resolved
internal/builders/maven/action.yml Outdated Show resolved Hide resolved
internal/builders/maven/action.yml Outdated Show resolved Hide resolved
@ianlewis
Copy link
Member

ianlewis commented Aug 7, 2023

Thanks. You could do some verification on the path to make sure it's under the workspace, something like https://github.com/slsa-framework/slsa-github-generator/blob/main/.github/actions/secure-download-artifact/action.yml#L42-L48

TBF, I believe the chdir would happen in the "untrusted" build's job anyway. So I don't think this is super important (though necessary if it's used elsewhere).

internal/builders/maven/action.yml Outdated Show resolved Hide resolved
internal/builders/maven/action.yml Outdated Show resolved Hide resolved
Signed-off-by: AdamKorcz <[email protected]>
@laurentsimon
Copy link
Collaborator

@AdamKorcz friendly ping to update this PR

@AdamKorcz
Copy link
Collaborator Author

@AdamKorcz friendly ping to update this PR

Thanks for the ping! Resolved the comments.

@laurentsimon laurentsimon enabled auto-merge (squash) August 15, 2023 17:55
@laurentsimon laurentsimon merged commit 324ff12 into slsa-framework:main Aug 15, 2023
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants