Comma after url

[LeventErkok]

Is this intentional?

$ cat a
testing http://www.cnn.com, here
$ brok a
*** Checking URLs ***
Fetching complete

*** Results ***

[a]
- Could not connect: http://www.cnn.com,

I can see the argument that ',' shouldn't terminate perhaps; but followed by a space (or end of line/file), it might be a good terminator?

[smallhadroncollider]

Hmm. This was my first attempt at writing a parser. I think it's a bit too lenient about where characters can be in a URL. Think I need to look at the URL spec in a bit more detail.

I've added a failing test for this. Will try and get it sorted in the next few days.

[smallhadroncollider]

Got the parser working on the above example, but it seems to have broken my caching file parsing...

[LeventErkok]

Thanks! I'd appreciate a new hackage release if it's not too much trouble!

[smallhadroncollider]

Done

[smallhadroncollider]

Please do let me know if you find any other URLs that don't work as expected. Or if you're aware of a big list of URLs that I can test against. I'm mostly just using my teaching notes for tests, but that's a fairly limited set.

[LeventErkok]

Just tested it, and looks great for my use case! Much appreciated. (Though I do have a feature request, will open a new issue.)