Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tolerate array and optional EDIFACT segments that exceed their maximum bounds #241

Closed
cjmamo opened this issue Aug 27, 2023 · 0 comments · Fixed by #243
Closed

Tolerate array and optional EDIFACT segments that exceed their maximum bounds #241

cjmamo opened this issue Aug 27, 2023 · 0 comments · Fixed by #243
Assignees
@cjmamo
Labels
type: enhancement
Milestone
v2.0.0-RC3

Comments

@cjmamo
Copy link
Member

cjmamo commented Aug 27, 2023

Expected Behavior

Tolerate array and optional EDIFACT segments that exceed their maximum bounds.

Current Behavior

The EDIFACT cartridge jumps to a BadMessage event when an array or an optional segment exceeds its maximum bounds. Organisations might have their own flavour of the UN implementation guidelines but the EDIFACT reader should still tolerate these small validation errors so that the user doesn't need to edit the DFDL schema.

Context

See the discussion in the Smooks user forum for the motivation behind this enhancement.
@cjmamo cjmamo added this to the v2.0.0-RC3 milestone Aug 27, 2023
@cjmamo cjmamo self-assigned this Aug 27, 2023
cjmamo added a commit to cjmamo/smooks-dfdl-cartridge that referenced this issue Aug 27, 2023
@cjmamo
feat!: control whether errors bubble up using validation mode so that s…
3a7b118 
…mooks/smooks-edi-cartridge#241 can be supported
@cjmamo cjmamo mentioned this issue Aug 27, 2023
Merged
cjmamo added a commit to smooks/smooks-dfdl-cartridge that referenced this issue Aug 27, 2023
@cjmamo
feat!: control whether errors bubble up using validation mode so that s…
a98394c 
…mooks/smooks-edi-cartridge#241 can be supported (#146)
cjmamo added a commit to cjmamo/smooks-edi-cartridge that referenced this issue Aug 28, 2023
@cjmamo
feat: implement smooks#241
2833be8
@cjmamo cjmamo linked a pull request Aug 28, 2023 that will close this issue
feat: implement #241 #243
Merged
cjmamo added a commit to cjmamo/smooks-edi-cartridge that referenced this issue Aug 30, 2023
@cjmamo
feat: add occursCountKind=parsed to EDIFACT segments in generated DFD…
63d53fa 
…L schemas to implement smooks#241
cjmamo added a commit to cjmamo/smooks-edi-cartridge that referenced this issue Aug 30, 2023
@cjmamo
feat: add occursCountKind=parsed to EDIFACT segments in generated DFD…
15fdbff 
…L schemas to implement smooks#241
cjmamo added a commit that referenced this issue Aug 31, 2023
@cjmamo
feat: add occursCountKind=parsed to EDIFACT segments in generated DFD…
847ed7b 
…L schemas to implement #241 (#243)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjmamo cjmamo

Labels
type: enhancement
Milestone
v2.0.0-RC3
Development

Successfully merging a pull request may close this issue.

feat: implement #241 cjmamo/smooks-edi-cartridge
1 participant
@cjmamo