Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(ActionTimeout): add garbage collection time tracking #418

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maxblan
Copy link
Contributor

@maxblan maxblan commented Apr 26, 2023

This commit adds a new variable gcTime to the ActionTimeout class and subtracts it from the total time when calculating the time difference between the start and stop timestamps. The gcTime variable is calculated by iterating over the list of Garbage Collector MXBeans and summing up the collection times. This change improves the accuracy of the time tracking by accounting for the time spent in garbage collection.

These changes has not been tested, but are more a idea to be presended.

…nTimeout class

This commit adds a new variable gcTime to the ActionTimeout class and subtracts it from the total time when calculating the time difference between the start and stop timestamps. The gcTime variable is calculated by iterating over the list of Garbage Collector MXBeans and summing up the collection times. This change improves the accuracy of the time tracking by accounting for the time spent in garbage collection.
@maxblan maxblan requested a review from xeruf as a code owner April 26, 2023 21:44
@xeruf
Copy link
Member

xeruf commented Apr 30, 2023

Did not expect that this is even possible, interesting!
But I think we have to wait for next season so we have sufficient time for testing in practice.

@xeruf xeruf added this to the 24 milestone Apr 30, 2023
@xeruf xeruf modified the milestones: 24, long-term Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants