Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🤔 correct clear button color in form fields #1193

Closed
5 of 11 tasks
coraliefeil opened this issue Jul 6, 2024 · 0 comments
Closed
5 of 11 tasks

fix: 🤔 correct clear button color in form fields #1193

coraliefeil opened this issue Jul 6, 2024 · 0 comments
Assignees
@auroraVasconcelos
Labels
A11y 🔧 code needs changes in code 🎨 figma needs changes in Figma

Comments

@coraliefeil
Copy link
Contributor

coraliefeil commented Jul 6, 2024 •
edited by yoezlem
Loading

Current behavior

Button color for clear button is neutral-500 which has insufficient contrast on white and neutral-200 (hover) background.

Expected behavior

Button color for clear button is neutral-800 which has sufficient contrast on white and neutral-200 (hover) background.

Technical Information

  • Update & publish figma components sd-input, sd-input/sample-autosuggest, sd-select

  • Update & merge storybook sd-input, sd-select

DoR

  • Item has business value
  • Item has been estimated by the team
  • Item is clear and well-defined
  • Item dependencies have been identified

DoD

  • Documentation has been created/updated (if applicable)
  • Migration Guide has been created/updated (if applicable)
  • Relevant E2E tests (Features, A11y, Bug fixes) are created/updated
  • Relevant stories (Features, A11y) are created/updated
  • Implementation works successfully on feature branch
@coraliefeil coraliefeil added 🎨 figma needs changes in Figma 🔧 code needs changes in code A11y labels Jul 6, 2024
@yoezlem yoezlem removed their assignment Jul 12, 2024
@auroraVasconcelos auroraVasconcelos self-assigned this Jul 16, 2024
karlbaumhauer pushed a commit that referenced this issue Jul 30, 2024
@semantic-release-bot
chore(release/components): 3.10.2 [skip actions]
c3ef257 
# [@solid-design-system/components-v3.10.2](components/3.10.1...components/3.10.2) (2024-07-30)

### Bug Fixes

* [#1193](#1193) correct clear button color in sd-icon and sd-select ([#1217](#1217)) ([0fa1fd2](0fa1fd2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@auroraVasconcelos auroraVasconcelos

Labels
A11y 🔧 code needs changes in code 🎨 figma needs changes in Figma
Projects
Solid Design System Project Board
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@coraliefeil @auroraVasconcelos @yoezlem