[GUI]: Ensure that the UI settings are saved before restarting Sonic Pi

sonic-pi-net · Apr 27, 2021 · 90ccfee · 90ccfee
1 parent a2b1b17
commit 90ccfee
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/app/gui/qt/mainwindow.cpp b/app/gui/qt/mainwindow.cpp
@@ -3243,6 +3243,9 @@ void MainWindow::writeSettings()
     gui_settings->setValue("docsplitState", docsplit->saveState());
     gui_settings->setValue("windowState", saveState());
     gui_settings->setValue("windowGeom", saveGeometry());
+
+    // Force Qt to write the settings to the ini file
+    gui_settings->sync();
 }
 
 void MainWindow::loadFile(const QString& fileName, SonicPiScintilla*& text)
@@ -3339,9 +3342,7 @@ void MainWindow::restartApp() {
     // Save settings and perform some cleanup
     writeSettings();
     onExitCleanup();
-    std::cout << "Performing application restart... please wait..." << std::endl;
-    // Allow cleanup to complete
-    std::this_thread::sleep_for(2s);
+    std::cout << "Performing application restart..." << std::endl;
 
     // Create new process
     QStringList args = qApp->arguments();

diff --git a/app/gui/qt/widgets/settingswidget.cpp b/app/gui/qt/widgets/settingswidget.cpp
@@ -83,6 +83,8 @@ SettingsWidget::SettingsWidget(int port, bool i18n, SonicPiSettings *piSettings,
  * Destructor
  */
 SettingsWidget::~SettingsWidget() {
+  // Set the settings before exiting
+  updateSettings();
 }
 
 QSize SettingsWidget::sizeHint() const
@@ -549,6 +551,7 @@ void SettingsWidget::updateScopeKindVisibility() {
 void SettingsWidget::updateSelectedUILanguage(QString lang) {
   int index = available_languages.indexOf(lang);
   language_combo->setCurrentIndex(index);
+  updateSettings();
 }
 
 void SettingsWidget::toggleScope( QWidget* qw ) {