Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs in *ASMBackend bytecode version computation #1694

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tim-hoffman
Copy link
Member

Also, add ASM validator and a test case for the 1.8 bug.

The fixed bugs are:

  1. bytecode version was not high enough when using special invoke to call a default method. There was no check for this case but it requires version 1.8.
  2. AbstractASMBackend previously stopped increasing the version number if at least 1.8 was necessary for some method which may have missed a higher version number being required by a later method! The fix was to check the MAX version number instead.

…dator and a test case for the 1.8 bug

1. bytecode version was not high enough when using special invoke to call a default method
2. AbstractASMBackend previously stopped increasing the version number if at least 1.8 was necessary for some method which may have missed a higher version number being required by a later method! The fix was to check the MAX version number instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant