Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing header in synthesized profiled program #2186

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

quentin
Copy link
Member

@quentin quentin commented Feb 8, 2022

Logger.h was missing in synthesized profiled programs.

The current tests in tests/profile only check interpreted profiled program, hence missing this issue introduced by 81b9cf2

The only test that capture the issue is tests/example/profile_default but examples are not run as part of the continuous integration. Should they ?

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #2186 (1b51ae6) into master (bfc54a5) will decrease coverage by 0.05%.
The diff coverage is 79.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2186      +/-   ##
==========================================
- Coverage   75.59%   75.54%   -0.06%     
==========================================
  Files         452      452              
  Lines       27259    27260       +1     
==========================================
- Hits        20607    20594      -13     
- Misses       6652     6666      +14     
Impacted Files Coverage Δ
src/ast/Aggregator.h 100.00% <ø> (ø)
src/ast/Clause.h 100.00% <ø> (ø)
src/ast/FunctorDeclaration.cpp 38.09% <ø> (ø)
src/ast/analysis/typesystem/Type.cpp 45.84% <0.00%> (ø)
src/ast/analysis/typesystem/TypeSystem.h 84.33% <0.00%> (ø)
src/ast/transform/InlineRelations.cpp 66.10% <0.00%> (ø)
src/ast/transform/RemoveRedundantSums.cpp 50.00% <0.00%> (ø)
src/ast/utility/SipsMetric.cpp 21.33% <ø> (ø)
src/ast/utility/Utils.cpp 91.47% <ø> (ø)
src/ast/utility/Utils.h 100.00% <ø> (ø)
... and 47 more

Copy link
Member

@b-scholz b-scholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants