emit missing '\n' in cpp includes #2206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the added newlines this generates C++
which does not always compile, e.g.
```
compiler error: cannot compile source file "./soufflepxyz.cpp"
./soufflepxyz.cpp:4:36: warning: extra tokens at end of #include directive [-Wextra-tokens]
#include "souffle/profile/Logger.h"#include "souffle/profile/ProfileEvent.h"
^
```
Codecov Report
@@ Coverage Diff @@
## master #2206 +/- ##
==========================================
- Coverage 75.52% 75.51% -0.01%
==========================================
Files 452 452
Lines 27394 27394
==========================================
- Hits 20689 20687 -2
- Misses 6705 6707 +2
|
b-scholz
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the added newlines this generates C++
which does not always compile, e.g.