Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatability problems with version 5.0.2 #70

Open
albenik85 opened this issue Jun 29, 2022 · 8 comments · May be fixed by #74
Open

compatability problems with version 5.0.2 #70

albenik85 opened this issue Jun 29, 2022 · 8 comments · May be fixed by #74

Comments

@albenik85
Copy link

Hi all,

I just updated my redmine installation to version 5.0.2 and it seems like this plugin is not compatible with it. I changed the version of deep_clonable to 3.2.0 as the used reference was not compatible with rails 6.1.6. Bundle install was succesfull but during db migration I received
"LoadError: cannot load such file -- redmine_recurring_tasks"

Was anybody able to use this plugin with 5.0.x already?

@mensfeld
Copy link

mensfeld commented Jul 1, 2022

Yeah, same problem here

@mensfeld
Copy link

mensfeld commented Jul 1, 2022

Ok managed to fix. Trivial.

Just do this in the init.rb (aside from removing the deep clone reference you already did:

at the top (before anything else:

# remove this line with require
require 'redmine_recurring_tasks'

# and replace with those two
require 'redmine'
require_relative 'lib/redmine_recurring_tasks'

at the end of init.rb (after all)

require File.dirname(__FILE__) + '/lib/redmine_recurring_tasks'

migrate and ready to go

@albenik85
Copy link
Author

Great, I can confirm that your solution is working.
Thanks a lot!

@mensfeld
Copy link

mensfeld commented Jul 1, 2022

@albenik85 it's working and loads the plugin but dispatching is still broken as deep clone fails. I will fix this today and submit the fix here.

@mensfeld
Copy link

mensfeld commented Jul 1, 2022

Ok, no additional code changes needed. After you apply the code I placed above, the only remaining thing is to reset the copied associations:

Zrzut ekranu z 2022-07-01 15-27-50

Just use the reset and save. Then all should work as expected.

@Godfatherbobo
Copy link

Looks like that works but im now missing the top menu bar option "recurring tasks" that would take you to a list of current recurring tasks, is that missing for you guys as well?

@camlafit
Copy link

camlafit commented Sep 5, 2023

Hello

I've followed these information and looks ok also
Thanks

@camlafit
Copy link

camlafit commented Sep 5, 2023

To complete

before_filter has been deprecated in Rails 5.0 and removed in 5.1.
Then should be replaced by before_action in ./app/controllers/recurring_tasks_controller.rb and repl

camlafit added a commit to Webelys/redmine_recurring_tasks that referenced this issue Sep 5, 2023
@camlafit camlafit linked a pull request Sep 5, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants