maintain oss-fuzz target building upstream #3093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For example: fuzzy-boiii23a/oss-fuzz@9d65673 |
|
Other than the missing newline, LGTM. |
|
Heh, now it has an extra newline, but that's fine. (Some tools treat the POSIX requirement that all lines in a text file end in a newline seriously was the only reason I mentioned it.) |
I used shfmt (https://github.com/mvdan/sh) and i also checked and there is a new line in the file locally unsure why git is not picking this up, sorry |
|
Thank you for your work on the fuzzer! LGTM. |
flavorjones
added a commit
that referenced
this pull request
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is needed so that i can update the oss-fuzz builder located at https://github.com/fuzzy-boiii23a/oss-fuzz/tree/master/projects/nokogiri which makes it much more seamless to add new fuzz targets in this nokogiri repo which will automatically be pulled by oss-fuzz and fuzzed instead of maintaining the fuzzer in the oss-fuzz repo.