-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: paper edits #153
docs: paper edits #153
Conversation
@kjappelbaum thanks for this! I've appreciated the insights, involvement, and code contributions you've made. I'm not sure why it wasn't compiling on the site you mentioned, but the draft-pdf CI workflow seems to have gone OK. https://github.com/sparks-baird/xtal2png/actions/runs/2631558919 |
- drop grayscale - material informatics --> materials informatics (https://en.wikipedia.org/wiki/Materials_informatics) - mention the "multiple discovery" (really "multiple domain transfer") of Roost and CrabNet, i.e. sometimes the multiple year periods of domain transfer can result in significant overlapping work among multiple research groups - correlates --> corresponding applications
Feel free to take another pass if you'd like to look at the touch-ups I made, otherwise will merge. Thanks again for going through this! |
also didn't understand this - used this in the past to get the PDF without re-triggering actions. Thanks also for the touchups! |
Ah, gotcha. Just not sure why it's working for the CI but not the site you linked.
The usage here seemed fine to me based on what's shown in the docs:
|
First, thanks for adding me to the author list. I'm happy to be on it, but only if you consider my contributions worth it.
I went through your paper draft and performed some changes. I tried to do small commits, such that one can cherry-pick/drop some. (My commit prefixes
docs
are because I'm used to conventional commits.)I'm not a native speaker though - therefore, some edits might make it worse.
Note: I'm still trying to fix the non-compilation issue (https://whedon.theoj.org/preview):