Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement click CLI #154

Merged
merged 11 commits into from
Jul 8, 2022
Merged

feat: implement click CLI #154

merged 11 commits into from
Jul 8, 2022

Conversation

kjappelbaum
Copy link
Contributor

@kjappelbaum kjappelbaum commented Jul 7, 2022 •
edited
Loading

closes xtal2png without arguments throws ValueError #145

ToDo:

  • test
  • check if docs still apply

feat: implement click CLI
62511f7 
closes `xtal2png` without arguments throws `ValueError` sparks-baird#145
@kjappelbaum kjappelbaum linked an issue Jul 7, 2022 that may be closed by this pull request
xtal2png without arguments throws ValueError #145
Closed
@kjappelbaum kjappelbaum marked this pull request as draft July 7, 2022 21:33
@kjappelbaum kjappelbaum changed the title [WIP] feat: implement click CLI feat: implement click CLI Jul 8, 2022
@kjappelbaum kjappelbaum marked this pull request as ready for review July 8, 2022 00:14
sgbaird
sgbaird approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@sgbaird sgbaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together! I'll probably use this as a template for any future cli I implement. Nice demo of click!

@sgbaird sgbaird merged commit 4ae7088 into sparks-baird:main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgbaird sgbaird sgbaird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xtal2png without arguments throws ValueError
2 participants
@kjappelbaum @sgbaird