Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test example #188

Merged
merged 18 commits into from
Jul 29, 2022
Merged

chore: test example #188

merged 18 commits into from
Jul 29, 2022

Conversation

kjappelbaum
Copy link
Contributor

No description provided.

@kjappelbaum kjappelbaum linked an issue Jul 25, 2022 that may be closed by this pull request
2 tasks
@kjappelbaum
Copy link
Contributor Author

perhaps not that important ;)

but a good time for a new release :)

@kjappelbaum
Copy link
Contributor Author

perhaps we should run simply doctest on the readme ...

@sgbaird
Copy link
Member

sgbaird commented Jul 28, 2022

@kjappelbaum, I reran the tests and it was fine (maybe you noticed the "coveralls busy" error). Ok to merge?

@kjappelbaum
Copy link
Contributor Author

let me check if it actually ran the doctests on the README :)

@sgbaird
Copy link
Member

sgbaird commented Jul 28, 2022

No rush. Thx!

@kjappelbaum
Copy link
Contributor Author

the stuff that m3gnet printed to stdout threw the doctest off. Works now. If you're fine with the changes, it's ready to merge.

@sgbaird sgbaird merged commit e09de98 into sparks-baird:main Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JOSS paper review - Installation docs
2 participants