Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

response to rkurchin's editorial review #192

Merged
merged 9 commits into from
Jul 28, 2022
Merged

response to rkurchin's editorial review #192

merged 9 commits into from
Jul 28, 2022

Conversation

sgbaird
Copy link
Member

@sgbaird sgbaird commented Jul 28, 2022

openjournals/joss-reviews#4528 (comment)

line 10: "natural language" -> "natural language processing"
11: capitalize and add a comma after Transformers (also capitalize in other places it shows up, e.g. line 23)
15: delete "respectively"
22: be consistent with citation formatting, put Vaswani et al. inside citation
23: semicolon should be a comma (second clause could not be a sentence on its own)
lines 31 and 33: something weird is happening with the double-parentheses for citation
60: either add a comma after before "which" or change it to "that"
@sgbaird sgbaird changed the title add bibtex entries for VAEs and DDPMs response to rkurchin's editorial review Jul 28, 2022
@sgbaird sgbaird marked this pull request as ready for review July 28, 2022 22:04
@sgbaird sgbaird merged commit 85d3784 into main Jul 28, 2022
@sgbaird sgbaird deleted the response-to-rkurchin branch July 28, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant