Merge pull request #239 from simPod/strict-child

Read `#[Strict]` also from parent classes

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 All notable changes to `data-transfer-object` will be documented in this file
 
+## Unreleased
+
+- `#[Strict]` is passed down the inheritance chain so children are strict when parent is strict (#239)
+
 ## 3.7.1 - 2021-09-09
 
 - Cast properties with self or parent type (#236)

src/Reflection/DataTransferObjectClass.php

@@ -2,6 +2,7 @@
 
 namespace Spatie\DataTransferObject\Reflection;
 
+use ReflectionAttribute;
 use ReflectionClass;
 use ReflectionProperty;
 use Spatie\DataTransferObject\Attributes\Strict;
@@ -66,6 +67,19 @@ public function validate(): void
 
     public function isStrict(): bool
     {
-        return $this->isStrict ??= ! empty($this->reflectionClass->getAttributes(Strict::class));
+        if (!isset($this->isStrict)) {
+            $attribute = null;
+
+            $reflectionClass = $this->reflectionClass;
+            while ($attribute === null && $reflectionClass !== false) {
+                $attribute = $reflectionClass->getAttributes(Strict::class)[0] ?? null;
+
+                $reflectionClass = $reflectionClass->getParentClass();
+            }
+
+            $this->isStrict = $attribute !== null;
+        }
+
+        return $this->isStrict;
     }
 }

tests/StrictDtoTest.php

@@ -25,6 +25,17 @@ public function strict_test()
         $this->expectException(UnknownProperties::class);
 
         $dto = new StrictDto(
+            name:    'name',
+            unknown: 'unknown'
+        );
+    }
+
+    /** @test */
+    public function strict_child_test()
+    {
+        $this->expectException(UnknownProperties::class);
+
+        $dto = new ChildStrictDto(
             name: 'name',
             unknown: 'unknown'
         );
@@ -37,6 +48,9 @@ class StrictDto extends DataTransferObject
     public string $name;
 }
 
+final class ChildStrictDto extends StrictDto {}
+
+
 class NonStrictDto extends DataTransferObject
 {
     public string $name;