Read #[Strict] also from parent classes

spatie · Sep 14, 2021 · 59422d5 · 59422d5
1 parent 7960781
commit 59422d5
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/src/Reflection/DataTransferObjectClass.php b/src/Reflection/DataTransferObjectClass.php
@@ -2,6 +2,7 @@
 
 namespace Spatie\DataTransferObject\Reflection;
 
+use ReflectionAttribute;
 use ReflectionClass;
 use ReflectionProperty;
 use Spatie\DataTransferObject\Attributes\Strict;
@@ -66,6 +67,15 @@ public function validate(): void
 
     public function isStrict(): bool
     {
-        return $this->isStrict ??= ! empty($this->reflectionClass->getAttributes(Strict::class));
+        $attribute = null;
+
+        $reflectionClass = $this->reflectionClass;
+        while ($attribute === null && $reflectionClass !== false) {
+            $attribute = $reflectionClass->getAttributes(Strict::class)[0] ?? null;
+
+            $reflectionClass = $reflectionClass->getParentClass();
+        }
+
+        return $this->isStrict ??= $attribute !== null;
     }
 }
diff --git a/tests/StrictDtoTest.php b/tests/StrictDtoTest.php
@@ -25,6 +25,17 @@ public function strict_test()
         $this->expectException(UnknownProperties::class);
 
         $dto = new StrictDto(
+            name:    'name',
+            unknown: 'unknown'
+        );
+    }
+
+    /** @test */
+    public function strict_child_test()
+    {
+        $this->expectException(UnknownProperties::class);
+
+        $dto = new ChildStrictDto(
             name: 'name',
             unknown: 'unknown'
         );
@@ -37,6 +48,9 @@ class StrictDto extends DataTransferObject
     public string $name;
 }
 
+final class ChildStrictDto extends StrictDto {}
+
+
 class NonStrictDto extends DataTransferObject
 {
     public string $name;