Merge pull request #178 from bastien-phi/nested_dto_having_casted_field

Fix when nested DTO have casted field

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 All notable changes to `data-transfer-object` will be documented in this file
 
+## 3.0.3 - 2021-05-08
+
+- Fix when nested DTO have casted field (#178)
+
 ## 3.0.2 - 2021-04-02
 
 - Allow valid DTOs to be passed to caster (#177)

src/Reflection/DataTransferObjectProperty.php

@@ -100,7 +100,7 @@ private function resolveCasterFromType(): array
         $reflectionClass = new ReflectionClass($type->getName());
 
         do {
-            $attributes = $reflectionClass->getAttributes();
+            $attributes = $reflectionClass->getAttributes(CastWith::class);
 
             $reflectionClass = $reflectionClass->getParentClass();
         } while (! count($attributes) && $reflectionClass);
@@ -125,6 +125,6 @@ private function resolveCasterFromDefaults(): ?Caster
             }
         }
 
-        dd($defaultCastAttributes);
+        return null;
     }
 }

tests/DataTransferObjectTest.php

@@ -4,6 +4,7 @@
 
 use Spatie\DataTransferObject\Tests\Dummy\BasicDto;
 use Spatie\DataTransferObject\Tests\Dummy\ComplexDto;
+use Spatie\DataTransferObject\Tests\Dummy\ComplexDtoWithCastedAttributeHavingCast;
 use Spatie\DataTransferObject\Tests\Dummy\ComplexDtoWithNullableProperty;
 
 class DataTransferObjectTest extends TestCase
@@ -62,6 +63,24 @@ public function create_with_null_nullable_nested_dto()
         $this->assertNull($dto->other);
     }
 
+    /** @test */
+    public function create_with_nested_dto_having_cast()
+    {
+        $dto = new ComplexDtoWithCastedAttributeHavingCast([
+            'name' => 'a',
+            'other' => [
+                'name' => 'b',
+                'object' => [
+                    'name' => 'c',
+                ],
+            ],
+        ]);
+
+        $this->assertEquals('a', $dto->name);
+        $this->assertEquals('b', $dto->other->name);
+        $this->assertEquals('c', $dto->other->object->name);
+    }
+
     /** @test */
     public function all_with_nested_dto()
     {

tests/Dummy/ComplexDtoWithCast.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace Spatie\DataTransferObject\Tests\Dummy;
+
+use Spatie\DataTransferObject\Attributes\DefaultCast;
+use Spatie\DataTransferObject\DataTransferObject;
+
+#[DefaultCast(ComplexObject::class, ComplexObjectCaster::class)]
+class ComplexDtoWithCast extends DataTransferObject
+{
+    public string $name;
+
+    public ComplexObject $object;
+}

tests/Dummy/ComplexDtoWithCastedAttributeHavingCast.php

@@ -0,0 +1,12 @@
+<?php
+
+namespace Spatie\DataTransferObject\Tests\Dummy;
+
+use Spatie\DataTransferObject\DataTransferObject;
+
+class ComplexDtoWithCastedAttributeHavingCast extends DataTransferObject
+{
+    public string $name;
+
+    public ComplexDtoWithCast $other;
+}