This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Fix union type casting #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I already had this ready in a separate branch, but I'm happy to merge your implementation :) Will tag later today |
|
FYI I removed the null branch in the match block, that should never happen. |
|
Tagged as 3.0.4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now properties with a union type are not supported because the
resolveCasterFromTypemethod inDataTransferObjectPropertyclass throw an exception in the$type->getName()call (ThegetNamemethod does not exists inReflectionUnionType.I don't know if the solution I implemented is the best solution but in my tests it works.