Set boolean to class_implements

[doox911-opensource]

Why class name?

https://www.php.net/manual/en/function.class-implements.php

The second parameter is boolean. I understand that there will be a cast, but still.

[jdreesen]

Should be this then, I think:

Suggested change

	if (! class_implements($this->casterClass, true)) {
	if (! in_array(Caster::class, class_implements($this->casterClass, true), true) {

Or maybe:

Suggested change

	if (! class_implements($this->casterClass, true)) {
	if (! is_a($this->casterClass, Caster::class, true)) {

[doox911-opensource]

I meant that it will always be true here. A list of interfaces is also required here.

[jdreesen]

Yes, you are right. But I don't think the check makes sense at all. Would be strange to check if $this->casterClass just implements something. The intention was probably to check if it implements Caster::class.

[brendt]

That's absolutely my bad; it should have been is_subclass_of. I'll fix this later this week.

[jdreesen]

I think we need the third parameter to be true here, because the first one is a string.

Suggested change

	if (! is_subclass_of($this->casterClass, Caster::class)) {
	if (! is_subclass_of($this->casterClass, Caster::class, true)) {

[doox911-opensource]

What for? There is true by default.

[jdreesen]

Oh, you're right! I was confused because for is_a() it's default false....

[brendt]

Thanks!