This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Promoted dataTransferObject and validationErrors #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Just started using the library, and we're really enjoying it.
One use case that isn't easily supported (as far as I can see) is being able to access the results of a ValidationException – at present they are concatenated into a string.
This doesn't really work for our use case as we need to access individual messages and perform post-processing on the exceptions.
There's a number of ways that this could be done, but I thought the least invasive would be making the validationErrors available as a property (dataTransferObject has been promoted more for completeness).