This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug when a type property has the
self
orparent
keyword.Here is a simple example with a nullable self property:
The same applies for the
parent
keyword.The reason is that the
DataTransferObjectProperty
cannot resolve the caster (e.g.DataTransferObjectCaster
) for the property, becauseresolveCasterFromType()
returns an empty array.This happens because
$type->getName()
returnsself
soclass_exists('self')
is false.In order to fix, this I'm parsing the type name and resolving the
self
andparent
keywords to the concrete classes.