Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap holidays check to end date when calculating diff #216

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

kylekatarnls
Copy link
Collaborator

@kylekatarnls kylekatarnls commented May 24, 2023

Fix #215

@kylekatarnls kylekatarnls force-pushed the feature/cap-search-to-end-date branch 2 times, most recently from bb1a91c to c7140ec Compare May 24, 2023 17:20
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 62.50% and project coverage change: -1.12 ⚠️

Comparison is base (a6b937b) 100.00% compared to head (f492e18) 98.88%.

❗ Current head f492e18 differs from pull request most recent head c7140ec. Consider uploading reports for the commit c7140ec to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@              Coverage Diff              @@
##              master     #216      +/-   ##
=============================================
- Coverage     100.00%   98.88%   -1.12%     
- Complexity       351      368      +17     
=============================================
  Files             22       23       +1     
  Lines            786      804      +18     
=============================================
+ Hits             786      795       +9     
- Misses             0        9       +9     
Impacted Files Coverage Δ
src/Exceptions/SearchLimitReached.php 0.00% <0.00%> (ø)
src/OpeningHours.php 98.28% <65.00%> (-1.72%) ⬇️
src/Helpers/DiffTrait.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kylekatarnls kylekatarnls force-pushed the feature/cap-search-to-end-date branch from 630d0d9 to be12631 Compare May 24, 2023 20:56
@kylekatarnls kylekatarnls changed the title Fix #215 Cap holidays check to end date when calculating diff Cap holidays check to end date when calculating diff May 24, 2023
@kylekatarnls kylekatarnls merged commit c7dba5d into master Jun 12, 2023
36 checks passed
@kylekatarnls kylekatarnls deleted the feature/cap-search-to-end-date branch June 12, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

diffInOpenMinutes() does not work if only one day is configured as open
2 participants