Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow date ranges as input #225

Merged
merged 5 commits into from
Nov 12, 2023
Merged

Allow date ranges as input #225

merged 5 commits into from
Nov 12, 2023

Conversation

kylekatarnls
Copy link
Collaborator

@kylekatarnls kylekatarnls commented Nov 5, 2023

Resolves #221

@kylekatarnls kylekatarnls added enhancement need tests Need unit tests needs documentation Need to be documented labels Nov 5, 2023
@kylekatarnls kylekatarnls self-assigned this Nov 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (036c228) 98.89% compared to head (dad39be) 100.00%.

❗ Current head dad39be differs from pull request most recent head 0b52892. Consider uploading reports for the commit 0b52892 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##                3.x      #225      +/-   ##
=============================================
+ Coverage     98.89%   100.00%   +1.10%     
- Complexity      350       365      +15     
=============================================
  Files            24        25       +1     
  Lines           815       856      +41     
=============================================
+ Hits            806       856      +50     
+ Misses            9         0       -9     
Files Coverage Δ
src/Exceptions/InvalidDateRange.php 100.00% <100.00%> (ø)
src/OpeningHours.php 100.00% <100.00%> (+1.64%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kylekatarnls kylekatarnls force-pushed the feature/date-ranges-input branch 3 times, most recently from adc955a to f59e4a1 Compare November 11, 2023 21:24
@kylekatarnls kylekatarnls removed the need tests Need unit tests label Nov 11, 2023
@kylekatarnls kylekatarnls removed the needs documentation Need to be documented label Nov 12, 2023
@kylekatarnls kylekatarnls merged commit 67ebe77 into 3.x Nov 12, 2023
26 checks passed
@kylekatarnls kylekatarnls deleted the feature/date-ranges-input branch November 12, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants