fix(completions): Complete map flags multiple times #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
marckhouzam
reviewed
Jul 28, 2024
gabe565
force-pushed
the
map-flag-complete-multiple
branch
2 times, most recently
from
1352900
to
8f82817
Compare
gabe565
force-pushed
the
map-flag-complete-multiple
branch
from
8f82817
to
411a8af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cobra currently allows Slice and Array flags to be completed multiple times, but it doesn't support multiple map flags like
stringToStringandstringToIntin the same way.This PR adds support for map flags to be set multiple times.