Fixed case where slow tests would fail due to fixture changing over time

spira · Apr 6, 2016 · 69369a7 · 69369a7
1 parent 475e000
commit 69369a7
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -52,7 +52,7 @@
     "gulp-typescript": "^2.7.6",
     "gulp-util": "^3.0.5",
     "inquirer": "^0.8.5",
-    "istanbul": "0.4.2",
+    "istanbul": "^1.0.0-alpha.2",
     "istanbul-instrumenter-loader": "0.1.3",
     "karma": "0.13.22",
     "karma-chai-plugins": "^0.7.0",

diff --git a/src/fixtures.spec.ts b/src/fixtures.spec.ts
@@ -4,9 +4,12 @@ import * as moment from "moment";
 import {IJwtToken, IUser} from "./ngJwtAuthInterfaces";
 
 let seededChance:Chance.Chance = new Chance(1);
+
+let loadedToken:string;
+
 export const fixtures = {
+    loginPrompt:null,
     user: {
-        _self: '/users/1',
         userId: 1,
         email: '[email protected]',
         firstName: seededChance.first(),
@@ -50,8 +53,10 @@ export const fixtures = {
     },
 
     get token(){
-
-        return fixtures.buildToken(); //no customisations
+        if (!loadedToken){
+            loadedToken = fixtures.buildToken(); //no customisations
+        }
+        return loadedToken; //this "caching" ensures the token is unchanged between tests if they take too long (otherwise the timestamps may differ)
     }
 };
 

diff --git a/src/service/ngJwtAuthService.spec.ts b/src/service/ngJwtAuthService.spec.ts
@@ -667,7 +667,6 @@ describe('Service tests', () => {
             let userToImpersonate = fixtures.userResponse;
 
             userToImpersonate.userId = 2;
-            userToImpersonate._self = '/users/2';
 
             let expectedToken = fixtures.buildToken({
                 data: {