Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install with homebrew ruby by default, if present #53

Merged
merged 5 commits into from
Feb 9, 2018

Conversation

nicksieger
Copy link

@nicksieger nicksieger commented Feb 8, 2018

What

  • Install brew gems with homebrew ruby by default, if homebrew ruby is installed
  • Fix issue where homebrew superenv shims were interfering with Ruby's ability to compile native extensions.

URLs

Links to bug tickets or user stories.

QA Plan

  • Pull down this branch and run:
PATH=./bin:$PATH brew gem install <gem>
  • Ensure that the gem installed successfully.
  • Inspect the binstub created for the gem and ensure that #!/usr/local/bin/ruby is at the top, indicating it is installed to use homebrew ruby.

- Still recognize `--homebrew-ruby`
- Allow `--system-ruby` to select /usr/bin/ruby
Shims break some installs of native extensions by confusing Ruby's own
compiler configuration. Specifically, the `make` shim adds a homebrew
superenv option to "refurbish args" which then messes up the
command-line arguments to clang.
@emmahsax
Copy link

emmahsax commented Feb 9, 2018

bin vim op 120x60 2018-02-09 10-29-23

@anfleene
Copy link

anfleene commented Feb 9, 2018

@nicksieger This worked fine for me:

[~/sportsengine/brew-gem]$ PATH=./bin:$PATH brew gem install opsicle                                           
==> Fetching opsicle from gem source
Fetching: opsicle-2.10.1.gem (100%)
Downloaded opsicle-2.10.1
Warning: Cannot verify integrity of opsicle-2.10.1.gem
A checksum was not provided for this resource
For your reference the SHA256 is: 36490cc2b2fc68bfdc7cb4afa0dfb879c3978bc8853770955d08b40c71afccae
==> /usr/local/bin/gem install /Users/anfleene/Library/Caches/Homebrew/opsicle-2.10.1.gem --no-ri --no-rdoc --no-wrapper --no-user-install --install-dir /usr
🍺  /usr/local/Cellar/gem-opsicle/2.10.1: 1,271 files, 14.6MB, built in 18 seconds
PATH=./bin:$PATH brew gem install opsicle  12.81s user 4.71s system 80% cpu 21.761 total

@emmahsax
Copy link

emmahsax commented Feb 9, 2018

bin vim op 120x59 2018-02-09 11-43-17

@production-status-check
Copy link

:octocat: Has QA approval

@nicksieger nicksieger merged commit 1718e5b into master Feb 9, 2018
@emmahsax emmahsax deleted the default-homebrew-ruby branch July 14, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants