Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX of installation of brew-gems, RubyGems=>3.0.2 #57

Merged
merged 2 commits into from
Mar 29, 2019
Merged

FIX of installation of brew-gems, RubyGems=>3.0.2 #57

merged 2 commits into from
Mar 29, 2019

Conversation

JuPlutonic
Copy link

@JuPlutonic JuPlutonic commented Jan 7, 2019

IF RubyGems=>3.0.2 only supported parameter is --no-document
Where are some discussions here jordansissel/fpm#1583 and here jordansissel/fpm#1582 (If RubyGems < 2 this PR breaks installation)

IF RubyGems=>3.0.2 only supported parameter is --no-document
Where are some discussions here jordansissel/fpm#1583 and here jordansissel/fpm#1582
@JuPlutonic
Copy link
Author

JuPlutonic commented Jan 14, 2019

@sportngin please provide review and Merge/Close.
Thank you.

@nicksieger
Copy link

Could you make this compatible with both RubyGems 2.x and RubyGems 3 please?

@jasonkarns
Copy link

@nicksieger --no-document was introduced by RubyGems 2.x. Indeed, the ri/rdoc options were deprecated by 2.x and only just now completely dropped by 3.x

https://blog.rubygems.org/2013/02/24/2.0.0-released.html

@JuPlutonic
Copy link
Author

Yes, I see what the change is only drops RubyGems 1.x support

@nicksieger
Copy link

Ah, great, thanks for the clarification. And thanks for the contribution!

@nicksieger nicksieger merged commit 8a21987 into sportngin:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants