Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new provider: Aad #20

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kshitij-kasliwal
Copy link

No description provided.

@dsyer
Copy link
Collaborator

dsyer commented May 24, 2016

It would be useful to have some background here. What is AAD? Why do we care? Adding support for other providers is perhaps an interesting idea that we could implement as additional projects. We certainly don't want to replace the original facebook and github samples though, so this PR in its current form is unlikely to be applied. If you'd like to re-work it into a new sample app, and explain why you are doing it, that might be a good idea.

@dsyer dsyer changed the title Aad workaround Add a new provider: Aad Aug 2, 2016
@pivotal-issuemaster
Copy link

@kshitij-kasliwal Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@willmadison
Copy link

@dsyer AAD stands for Azure Active Directory. What I believe this PR is trying to accomplish is to make the existing Github and Facebook examples work for Microsoft Azure. We're running into the same issue on a project right now. Namely that the /token request to Microsoft Azure requires some additional fields in the body of the post. Specifically: client_id, resource, & client_secret. All of which seem to be omitted by default. Is there a more idiomatic way to enhance the token request on the fly? Could you point us in the direction of a solid example using Request Enhancers?

@gregturn gregturn changed the base branch from master to main April 27, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants