Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port BeanPropertyRowMapper and DataClassRowMapper for r2dbc #30530

Merged
merged 5 commits into from
May 25, 2023
Merged

Port BeanPropertyRowMapper and DataClassRowMapper for r2dbc #30530

merged 5 commits into from
May 25, 2023
+1,091 −0

Conversation

simonbasle
Copy link
Contributor

No description provided.

@simonbasle simonbasle mentioned this pull request May 23, 2023
Closed
@simonbasle
Copy link
Contributor Author

see discussion in gh-26021. cc @mp911de and @jhoeller

@simonbasle simonbasle self-assigned this May 23, 2023
@simonbasle simonbasle added in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement labels May 23, 2023
@simonbasle simonbasle added this to the 6.1.x milestone May 23, 2023
@simonbasle
Copy link
Contributor Author

@mp911de I have updated the PR to using Readable, but it is not a clear win over the previous version in my opinion due to the fact that I had to instanceof-check the concrete type in order to get the metadata about items (i.e. columns for Row and out param for OutParameters). let me know what you think

@mp911de
Copy link
Member

mp911de commented May 25, 2023

As Readable is not a sealed interface, you're right; there could be potential additional types. In practice, we haven't seen any being around. Also, there was no indication that someone would come up with an additional subtype that isn't a Row or OutParameters.

@simonbasle simonbasle marked this pull request as ready for review May 25, 2023 12:30
@simonbasle simonbasle modified the milestones: 6.1.x, 6.1.0-M1 May 25, 2023
@simonbasle simonbasle merged commit 5977bb0 into spring-projects:main May 25, 2023
@simonbasle simonbasle deleted the r2dbcBeanPropertyAndDataClassMappers branch May 25, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de mp911de left review comments

Assignees

@simonbasle simonbasle

Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-M1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simonbasle @mp911de