Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version was not able to generate types for headers in kebab-case.
Example:
would result in the following service definition:
The last line leads to a syntax error, due to the dashes in the parameter name.
Similar for the type generation of
IPlayAroundHeaderParameter
. The parameter name with dashes is not valid javascript code:An easy fix would be to add ' ' around the parameter names. However, the parameter names should follow the general code style and be in camelCase. It's also not a solution to convert the header parameter to camelCase and forget about its original name, because the original name is required in the header definition. Hence, this PR generates the code like this:
In the last line, we keep the original name of the parameter for the HTTP request, but the attribute of headerParameter is in camelCase.
Similar in the interface:
The changes are backwards-compatible. Parameters that were in camelCase before are still handled the same.